Re: psql should show disabled internal triggers

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, mailings(at)oopsware(dot)de
Subject: Re: psql should show disabled internal triggers
Date: 2014-02-24 18:09:29
Message-ID: 20140224180929.GH6718@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-02-24 12:45:12 -0500, Bruce Momjian wrote:
> On Wed, Feb 12, 2014 at 09:04:45PM -0500, Bruce Momjian wrote:
> > As others, I am concerned about people being confused when funny-looking
> > trigger names suddenly appearing when you disable all table triggers.
> >
> > What I ended up doing is to create a user and internal section when
> > displaying disabled triggers:
> >
> > Disabled user triggers:
> > check_update BEFORE UPDATE ON orders FOR EACH ROW EXECUTE PROCEDURE trigf()
> > Disabled internal triggers:
> > "RI_ConstraintTrigger_c_16409" AFTER INSERT ON orders FROM customer NOT DEF ...
> > "RI_ConstraintTrigger_c_16410" AFTER UPDATE ON orders FROM customer NOT DEF ...
> >
> > I kept the "Triggers" section unchanged, showing only user triggers. I
> > also updated the code to handle 8.3+ servers.
> >
> > Patch attached.
>
> Patch applied.

Thanks. It'd have been nice tho, to mention Fabrízio in the commit
message as the patch's author.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-02-24 18:16:39 Re: psql should show disabled internal triggers
Previous Message Bruce Momjian 2014-02-24 18:05:00 Re: Auto-tuning work_mem and maintenance_work_mem