Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication

Hi,

On 2014-02-21 14:15:09 +0100, Christian Kruse wrote:
> +/* ----------
> + * pgstat_fetch_stat_local_beentry() -
> + *
> + * Like pgstat_fetch_stat_beentry() but with local addtions (like xid and
> + * xmin values of the backend)

s/local addtions/locally computed addititions/

> +/* ----------
> + * LocalPgBackendStatus
> + *
> + * When we build the backend status array, we use LocalPgBackendStatus to be
> + * able to add new values to the struct when needed without adding new fields
> + * to the shared memory. It contains the backend status as a first member.
> + * ----------
> + */
> +typedef struct LocalPgBackendStatus
> +{
> + /*
> + * Local version of the backend status entry
> + */
> + PgBackendStatus backendStatus;
> +
> + /*
> + * The xid of the current transaction if available, InvalidTransactionId
> + * if not
> + */
> + TransactionId backend_xid;
> +
> + /*
> + * The xmin of the current session if available, InvalidTransactionId
> + * if not
> + */
> + TransactionId backend_xmin;
> +} LocalPgBackendStatus;
> +

Those are sentences, so they should include a . at the end.

I think this is ready for committer.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services