Re: Exposing currentTransactionWALVolume

Hi Simon,

On 2014-01-14 17:12:35 +0000, Simon Riggs wrote:
> /*
> - * MarkCurrentTransactionIdLoggedIfAny
> + * ReportTransactionInsertedWAL
> *
> - * Remember that the current xid - if it is assigned - now has been wal logged.
> + * Remember that the current xid - if it is assigned - has now inserted WAL
> */
> void
> -MarkCurrentTransactionIdLoggedIfAny(void)
> +ReportTransactionInsertedWAL(uint32 insertedWALVolume)
> {
> + currentTransactionWALVolume += insertedWALVolume;
> if (TransactionIdIsValid(CurrentTransactionState->transactionId))
> CurrentTransactionState->didLogXid = true;
> }

Not a big fan of combining those two. One works on the toplevel
transaction, the other on the current subtransaction... The new name
also ignores that it's only taking effect if there's actually a
transaction in progress.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services