Re: pgsql: pgindent: preserve blank lines around #else/#endif

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pgindent: preserve blank lines around #else/#endif
Date: 2014-02-13 21:52:40
Message-ID: 20140213215240.GG32126@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Feb 13, 2014 at 03:52:02PM -0500, Tom Lane wrote:
> >> else if (def->defnamespace == NULL)
> >> continue;
> >> +
> >> else if (pg_strcasecmp(def->defnamespace, namspace) != 0)
> >> continue;
> >>
> >> This seems an odd change to be making.
>
> > I just tested pgindent in head against that file in 9.3 and head and
> > didn't see that additional blank line, which is certainly odd.
>
> It doesn't do that for me either.

We have to expand our pgindent testing in the southern hemisphere. ;-)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-02-13 22:07:11 pgsql: docs: improve CREATE FUNCTION docs about language case and quoti
Previous Message Tom Lane 2014-02-13 20:52:02 Re: pgsql: pgindent: preserve blank lines around #else/#endif