Re: pgsql: pgindent: preserve blank lines around #else/#endif

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pgindent: preserve blank lines around #else/#endif
Date: 2014-02-13 20:01:21
Message-ID: 20140213200121.GU6342@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian wrote:
> On Thu, Feb 13, 2014 at 03:54:54PM -0300, Alvaro Herrera wrote:
> > Bruce Momjian wrote:
> > > pgindent: preserve blank lines around #else/#endif
> > >
> > > This requires a new version of pg_bsd_indent, version 1.3, to be
> > > downloaded.
> >
> > This is a bit of a mess. I now can't use 9.3's pgindent because it
> > wants to have pg_bsd_indent 1.2 installed, but I only have 1.3 because
> > the master branch requested it.
>
> Uh, I never thought people ran pgindent on old branches. Why would you
> want to do that?

Well, I wanted to make sure that the commit is identically indented in
all branches, and I worked in 9.3 first (rather unusually, I have to
admit.)

> You can certainly use head pgindent on 9.3 and it should output the
> same.

Yeah, it worked, although see my other followup.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-02-13 20:39:15 pgsql: pgcrypto: clarify 'md5' (hash) table entry
Previous Message Bruce Momjian 2014-02-13 19:58:14 Re: pgsql: pgindent: preserve blank lines around #else/#endif