Re: BUG #8399: inconsistent input of multidimensional arrays

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: borz_off(at)cs(dot)msu(dot)su, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #8399: inconsistent input of multidimensional arrays
Date: 2014-02-01 15:50:43
Message-ID: 20140201155043.GI31141@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Jan 31, 2014 at 09:49:56PM -0800, Joe Conway wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 01/31/2014 05:46 PM, Joe Conway wrote:
> > On 01/31/2014 05:11 PM, Bruce Momjian wrote:
> >> Joe, does this sound right?
>
> > Let me take a closer look...
>
> I had forgotten how convoluted the array code is ;-)
>
> Yes, it looks correct to me, although I think I would initialize
> nelems_last[i] to 0 rather than -1.

Thanks for the review. I went with zero as you suggested. Applied
patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
array.diff text/x-diff 2.9 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message targen 2014-02-01 18:41:47 BUG #9068: invalid YY_START on Unicode identifier escape syntax
Previous Message Joe Conway 2014-02-01 05:49:56 Re: BUG #8399: inconsistent input of multidimensional arrays