Re: mvcc catalo gsnapshots and TopTransactionContext

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: mvcc catalo gsnapshots and TopTransactionContext
Date: 2014-01-31 21:41:33
Message-ID: 20140131214133.GT19957@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 7, 2013 at 03:02:36PM -0400, Robert Haas wrote:
> On Fri, Oct 4, 2013 at 3:20 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > On 2013-10-04 15:15:36 -0400, Robert Haas wrote:
> >> Andres, are you (or is anyone) going to try to fix this assertion failure?
> >
> > I think short term replacing it by IsTransactionOrTransactionBlock() is
> > the way to go. Entirely restructuring how cache invalidation in the
> > abort path works is not a small task.
>
> Well, if we're going to go that route, how about something like the
> attached? I included the assert-change per se, an explanatory
> comment, and the test case that Noah devised to cause the current
> assertion to fail.

Is there any plan to commit this?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-01-31 21:56:00 Re: [HACKERS] Insert result does not match record count
Previous Message Tom Lane 2014-01-31 21:38:21 Re: [HACKERS] Insert result does not match record count