From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Joe Abbate <jma(at)freedomcircle(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: CREATE EVENT TRIGGER syntax |
Date: | 2014-01-30 18:52:00 |
Message-ID: | 20140130185200.GC20260@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Aug 9, 2013 at 09:12:03AM -0400, Robert Haas wrote:
> On Mon, Aug 5, 2013 at 4:53 PM, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >> So do we want to keep that "AND" in the 9.3beta and 9.4 documentation?
> >
> > The grammar as in gram.y still allows the AND form, and I think we're
> > used to maintain documentation that matches the code here. So I think it
> > makes sense to remove both capabilities as we failed to deliver any
> > other filter.
> >
> > But if we wanted to clean that, what about having the grammar check for
> > the only one item we support rather than waiting until into
> > CreateEventTrigger() to ereport a syntax error?
>
> I have found that it's generally better to recognize such errors in
> the post-parse phase rather than during parsing. When you start
> adding more options, that tends to quickly become the only workable
> option anyway.
OK, so I am assuming there is no additional work to do this area. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-01-30 18:52:55 | Re: pgindent behavior we could do without |
Previous Message | Pavel Stehule | 2014-01-30 18:50:49 | Review: tests for client programs |