| From: | Christian Kruse <christian(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() |
| Date: | 2014-01-29 20:37:54 |
| Message-ID: | 20140129203754.GE31325@defunct.ch |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 29/01/14 13:39, Tom Lane wrote:
> No, what I meant is that the ereport caller needs to save errno, rather
> than assuming that (some subset of) ereport-related subroutines will
> preserve it.
> […]
Your reasoning sounds quite logical to me. Thus I did a
grep -RA 3 "ereport" src/* | less
and looked for ereport calls with errno in it. I found quite a few,
attached you will find a patch addressing that issue.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| clang-patches-v1.patch | text/x-diff | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2014-01-29 20:46:42 | Re: jsonb and nested hstore |
| Previous Message | Pavel Stehule | 2014-01-29 20:26:43 | review: psql command copy count tag |