From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
Cc: | "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: A minor correction in comment in heaptuple.c |
Date: | 2014-01-25 21:28:09 |
Message-ID: | 20140125212809.GD9750@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 18, 2013 at 11:04:25AM -0700, Kevin Grittner wrote:
> D'Arcy J.M. Cain <darcy(at)druid(dot)net>
>
> > Although, the more I think about it, the more I think that the comment
> > is both confusing and superfluous. The code itself is much clearer.
>
> Seriously, if there is any comment there at all, it should be a
> succinct explanation for why we didn't do this (which passes `make
> check-world`):
Is everyone OK with me applying this patch from Kevin, attached?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
Attachment | Content-Type | Size |
---|---|---|
assert.diff | text/x-diff | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-01-25 21:29:36 | Re: A minor correction in comment in heaptuple.c |
Previous Message | Heikki Linnakangas | 2014-01-25 21:21:20 | Re: GIN improvements part2: fast scan |