From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-docs <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: remove undocumented assign syntax from plpgsql doc |
Date: | 2014-01-12 04:23:06 |
Message-ID: | 20140112042306.GM28089@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On Sat, Jan 11, 2014 at 10:06:27PM +0100, Pavel Stehule wrote:
>
>
>
> 2014/1/11 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Oh, I think you are right. I have reverted the patch. Attached is
> > proposed documentation for '='.
>
> Meh. Variable initialization is only one of multiple cases (assignment,
> GET DIAGNOSTICS; maybe others, I've not examined the grammar). Also,
> if we do it like this, we're implying that both := and = are equally
> preferred, which might not be the impression we want to leave.
>
>
> GET DIAGNOSTICS is defined by standard - and there "=" should be allowed only -
> although we allow ":=" too. It is a embedded SQL statement - although it is
> implemented as plpgsql statement.
OK, docs updated for that. I assume OPEN and FOR also can take := or =,
right?
> Same situation is with UPDATE statement - we don't allow ":=" there.
>
>
>
> I'd be a bit inclined to just stick a NOTE somewhere saying that "="
> can be used in place of ":=" for assignment.
>
>
> ok
>
> If we accept it and we close this topic, then following comment should be
> removed
>
> assign_operator : '=' /* not documented because it might be removed someday *
Comment updated. Patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
Attachment | Content-Type | Size |
---|---|---|
assign.diff | text/x-diff | 7.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2014-01-12 05:38:04 | Re: remove undocumented assign syntax from plpgsql doc |
Previous Message | Josh Berkus | 2014-01-12 03:20:57 | Re: Upgrading doc does not mention pg_restore at all |