| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Upgrade to Autoconf 2.69 |
| Date: | 2014-01-07 04:07:32 |
| Message-ID: | 20140107040732.GB30539@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Dec 29, 2013 at 02:48:21AM -0500, Tom Lane wrote:
> There are three or four different bugs here, but the key points are:
>
> 1. pg_resetxlog is diligently trashing every single WAL file in pg_xlog/,
> and then failing (by virtue of some ancient OS X bug in readdir()), so
> that it doesn't get to the point of recreating a WAL file with a
> checkpoint record.
>
> 2. pg_resetxlog already rewrote pg_control, which might not be such a hot
> idea; but whether it had or not, pg_control's last-checkpoint pointer
> would be pointing to a WAL file that is not in pg_xlog/ now.
>
> 3. pg_upgrade ignores the fact that pg_resetxlog failed, and keeps going.
Does pg_resetxlog return a non-zero exit status? If so, pg_upgrade
should have caught that and exited.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-01-07 04:40:53 | Re: [COMMITTERS] pgsql: Upgrade to Autoconf 2.69 |
| Previous Message | Peter Eisentraut | 2014-01-07 03:09:02 | pgsql: Add more use of psprintf() |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2014-01-07 04:37:29 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters |
| Previous Message | David Johnston | 2014-01-07 03:42:28 | Re: Fixing bug #8228 ("set-valued function called in context that cannot accept a set") |