| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: increase message string buffer size of watch command of psql |
| Date: | 2016-06-14 16:56:23 |
| Message-ID: | 20132.1465923383@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sun, Jun 12, 2016 at 10:55 AM, Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> wrote:
>>> Increase size of this title, please.
>>> 50 bytes is so small for multi language.
>>> And. I suggest that date string might be local language,
>>> or current_timestamp string.
>> This was already changed in commit dea2b5960.
> Well, we did part of that, but it's still using asctime(). Should we
> change that to strftime(..."%c"...) to be less English-centric?
> (The result seems to be the same in C locale. pg_controldata has done
> it that way for a long time, with few complaints.) If we want to do so,
> now would be the time, since 9.6 already whacked around the format
> of \watch output.
I take it from the vast silence that nobody particularly cares one way
or the other. On reflection I think that this would be a good change
to make, so I'll go do so unless I hear complaints soon.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-06-14 17:05:51 | Re: parallel.c is not marked as test covered |
| Previous Message | Tom Lane | 2016-06-14 16:51:25 | Re: parallel.c is not marked as test covered |