Bruce Momjian wrote:
> return STATUS_ERROR;
> }
>
> ! user_name = get_user_name(&errstr);
> ! if (!user_name)
> {
> ! ereport(LOG, (errmsg("%s\n", errstr)));
> ! pfree(errstr);
> return STATUS_ERROR;
> }
The message is already translated by get_user_name, so I think this
should use errmsg_internal() instead of errmsg(). Also, why do you add
a newline?
Not clear whether the new file should be in src/port or src/common.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services