| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files |
| Date: | 2013-12-03 16:33:56 |
| Message-ID: | 20131203163356.GD27105@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Dec 3, 2013 at 11:30:15AM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > libpq: change PQconndefaults() to ignore invalid service files
> > Previously missing or invalid service files returned NULL. Also fix
> > pg_upgrade to report "out of memory" for a null return from
> > PQconndefaults().
>
> Why does this patch remove the errorMessage argument from
> pg_fe_getauthname? I gauge the amount of thought that went into
> that choice by the fact that the comment wasn't updated.
Oh, the argument was not used, so I remove it. C comment updated.
Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-12-03 16:42:08 | Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files |
| Previous Message | Bruce Momjian | 2013-12-03 16:33:52 | pgsql: Update C comment for pg_fe_getauthname |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2013-12-03 16:35:45 | Re: Extension Templates S03E11 |
| Previous Message | Christian Kruse | 2013-12-03 16:33:02 | Re: Time-Delayed Standbys |