Re: [GENERAL] pg_upgrade ?deficiency

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Karsten Hilbert <Karsten(dot)Hilbert(at)gmx(dot)net>, "Hilbert, Sebastian" <Sebastian(dot)Hilbert(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] pg_upgrade ?deficiency
Date: 2013-11-30 21:53:38
Message-ID: 20131130215338.GD11181@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Fri, Nov 22, 2013 at 01:55:10PM -0800, Kevin Grittner wrote:
> Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
>
> This covers pg_dumpall globals.  Tested with a read-only postgres
> database and with default_transaction_read_only = on in the
> postgresql.conf file.
>
> It does nothing about pg_upgrade, which is sort of a separate
> issue.  My inclination is that connections to the new cluster
> should set this and connections to the old should not.

I have fixed pg_upgrade in git-head with the attached patch, which
prepends default_transaction_read_only=false to PGOPTIONS. I prepended
rather than appended because if PGOPTIONS had
default_transaction_read_only=true, I didn't want to override that.

While pg_dumpall would override that, that is more of an implementation
detail of having to set the value at the session level, rather than a
desired behavior.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
pg_upgrade.diff text/x-diff 1.1 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Noel Diaz 2013-11-30 21:56:52 Re: Full Stored Procedure Support, any time soon ?
Previous Message Alban Hertroys 2013-11-30 21:34:19 Re: Full Stored Procedure Support, any time soon ?

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2013-11-30 21:55:39 Re: Extension Templates S03E11
Previous Message Jeff Davis 2013-11-30 21:51:50 Re: Extension Templates S03E11