Re: Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: David Johnston <polobo(at)yahoo(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block
Date: 2013-11-26 17:02:37
Message-ID: 20131126170237.GB6321@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 26, 2013 at 08:54:13AM -0800, David Johnston wrote:
> How about:
>
> "Issuing <command> outside of a transaction has no effect and will provoke a
> warning."
>
> I dislike "does no harm" because it can if someone thinks the current state
> is different than reality.
>
> It is good to indicate that a warning is emitted if this is done in error;
> thus reinforcing the fact people should be looking at their warnings.
>
> "when not inside" uses a negative modifier while "outside" is more direct
> and thus easier to read, IMO. The phrase "transaction block" seems wordy so
> I omitted the word "block".

Every statement runs in a transaction so we can't omit "block".

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-11-26 17:07:07 Re: PL/Python: domain over array support
Previous Message Alvaro Herrera 2013-11-26 16:58:04 Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block