Re: Turning recovery.conf into GUCs

On 2013-11-19 22:24:19 -0500, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2013-11-19 22:09:48 +0900, Michael Paquier wrote:
> >> On Tue, Nov 19, 2013 at 2:27 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >>> * Why did you change some of the recovery gucs to lowercase names, but
> >>> left out XLogRestoreCommand?
>
> >> This was part of the former patch, perhaps you are right and keeping
> >> the names as close as possible to the old ones would make sense to
> >> facilitate maintenance across versions.
>
> > I think lowercase is slightly more consistent with the majority of the
> > other GUCs, but if you change it you should change all the new GUC variables.
>
> Please *don't* create any more mixed-case GUC names. The spelling of
> TimeZone and the one or two other historical exceptions was a very
> unfortunate thing; it's confused more people than it's helped.
> Put in some underscores if you feel a need for word boundaries.

That's a misunderstanding - I was only talking about the variables below
the GUCs, no the GUC's name. The patch changed quite some variable
names, around, but left others leaving an inconsistent casing of related
variables...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services