| From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Use MAP_HUGETLB where supported (v3) |
| Date: | 2013-11-18 07:29:52 |
| Message-ID: | 20131118072952.GA17956@toroid.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 2013-11-15 15:17:32 +0200, hlinnakangas(at)vmware(dot)com wrote:
>
> I spent some time whacking this around, new patch version attached.
Thanks.
> But I'm not wedded to the idea if someone objects; a log message might
> also be reasonable: "LOG: huge TLB pages are not supported on this
> platform, but huge_tlb_pages was 'on'"
Put that way, I have to wonder if the right thing to do is just to have
a "try_huge_pages=on|off" setting, and log a warning if the attempt did
not succeed. It would be easier to document, and I don't think there's
much point in making it an error if the allocation fails.
-- Abhijit
P.S. I'd be happy to do the followup work for this patch (updating
documentation, etc.), but it'll have to wait until I recover from
this !#$&@! stomach bug.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wangshuo | 2013-11-18 08:14:16 | Parse more than bind and execute when connect to database by jdbc |
| Previous Message | Alexey Klyukin | 2013-11-18 06:57:52 | Re: Wildcard usage enhancements in .pgpass |