| From: | Marko Kreen <markokr(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: appendPQExpBufferVA vs appendStringInfoVA |
| Date: | 2013-11-17 12:01:32 |
| Message-ID: | 20131117120132.GA10778@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 14, 2013 at 09:33:59PM +1300, David Rowley wrote:
> On Sun, Nov 3, 2013 at 3:18 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > I'm low on ideas on how to improve things much around here for now, but
> > for what it's worth, I did create a patch which changes unnecessary calls
> > to appendPQExpBuffer() into calls to appendPQExpBufferStr() similar to the
> > recent one for appendStringInfo and appendStringInfoString.
> >
> Attached is a re-based version of this.
It does not apply anymore, could you resend it?
I am bit suspicious of performance impact of this patch, but think
that it's still worthwhile as it decreases code style where single
string argument is given to printf-style function without "%s".
--
marko
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2013-11-17 15:20:01 | Re: pre-commit triggers |
| Previous Message | Ian Lawrence Barwick | 2013-11-17 11:47:11 | Review: pset autocomplete add missing options |