From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | [PATCH] warning: suggest braces around empty body in an 'else' statement |
Date: | 2013-11-07 23:00:39 |
Message-ID: | 20131107230039.GK28314@alap2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Compiling postgres I currently get the following warning when compiling
without LOCK_DEBUG:
/home/andres/src/postgresql/src/backend/storage/lmgr/lock.c:944:52:
warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
PROCLOCK_PRINT("LockAcquire: NOWAIT", proclock);
It'd be easy to just disable the warning with -Wno-empty-body, but I actually like
the warning.
It's easy to fix by defining PROCLOCK_PRINT to (void)0 instead of
defining it empty when LOCK_DEBUG is enabled.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
fix-suggest-braces-empty-body-warning.diff | text/x-diff | 518 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Joshua D. Drake | 2013-11-07 23:33:10 | Re: Changing pg_dump default file format |
Previous Message | Peter Eisentraut | 2013-11-07 22:13:01 | Re: Using indices for UNION. |