Re: RULE regression test fragility?

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RULE regression test fragility?
Date: 2013-10-25 14:11:22
Message-ID: 20131025141122.GA5627@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2013-10-25 10:50:57 -0300, Alvaro Herrera wrote:
> Andres Freund wrote:
> > On 2013-10-24 09:22:52 -0400, Tom Lane wrote:
> > > Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > > > FWIW, I've repeatedly now thought that it'd make maintaining/updating
> > > > patches easier if we switched that query into unaligned tuple only (\a
> > > > \t) mode. That would remove the frequent conflicts on the row count and
> > > > widespread changes due to changed alignment.
> > > > Alternatively we could just wrap the query in \copy ... CSV.
> > >
> > > Hm ... yeah, it would be a good thing if changes in one view didn't so
> > > frequently have ripple effects to the whole output. Not sure which
> > > format is best for that though.
> >
> > Something like the attached maybe?
>
> +1 (but what are those silly parens in pg_seclabels definition?),

That's because it contain several UNION ALLs and ruleutils makes sure
the order is correct.

> except:
>
> > +-- disable fancy output again
> > +\a\t
>
> Should be "enable".

Hrmpf. Fixed.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Don-t-use-aligned-output-in-some-regression-tests-to.patch text/x-patch 275.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-10-25 14:18:27 Re: Detection of nested function calls
Previous Message Alvaro Herrera 2013-10-25 13:50:57 Re: RULE regression test fragility?