| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, pavel(dot)stehule(at)gmail(dot)com |
| Subject: | Re: pgbench progress report improvements - split 3 v2 |
| Date: | 2013-09-26 03:49:06 |
| Message-ID: | 20130926034906.GB45039@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 24, 2013 at 10:41:17PM +0200, Fabien COELHO wrote:
> These changes are coupled because measures are changed, and their
> reporting as well. Submitting separate patches for these different
> features would result in conflicting or dependent patches, so I
> wish to avoid that if possible.
My feelings on the patch split haven't changed; your three bullet points call
for four separate patches. Conflicting patches are bad, but dependent patches
are okay; just disclose the dependency order. How about this: as a next step,
please extract just this feature that I listed last Saturday:
Patch (4): Redefine "latency" as reported by pgbench and report "lag" more.
Once that's committed, we can move on to others.
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2013-09-26 04:20:18 | Re: pgbench - exclude pthread_create() from connection start timing |
| Previous Message | Peter Geoghegan | 2013-09-26 03:48:11 | Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE |