Re: psql should show disabled internal triggers

On 2013-09-18 15:15:55 +0200, Bernd Helmle wrote:
>
>
> --On 18. September 2013 13:52:29 +0200 Andres Freund
> <andres(at)2ndquadrant(dot)com> wrote:
>
> >If you do ALTER TABLE ... DISABLE TRIGGER ALL; and then individually
> >re-enable the disabled triggers it's easy to miss internal triggers.
> >A \d+ tablename will not show anything out of the ordinary for that
> >situation since we don't show internal triggers. But foreign key checks
> >won't work.
> >So, how about displaying disabled internal triggers in psql?
>
> Hi had exactly the same concerns this morning while starting to look at the
> ENABLE/DISABLE constraint patch. However, i wouldn't display them as
> triggers, but maybe more generally as "disabled constraints" or such.

Well, that will lead the user in the wrong direction, won't it? They
haven't disabled the constraint but the trigger. Especially as we
already have NOT VALID and might grow DISABLED for constraint
themselves...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services