Re: [PATCH] Revive line type

From: David Fetter <david(at)fetter(dot)org>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, rui hua <365507506hua(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Revive line type
Date: 2013-09-16 22:57:03
Message-ID: 20130916225703.GA24324@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

On Mon, Sep 16, 2013 at 07:04:32PM -0300, Alvaro Herrera wrote:
> Peter Eisentraut escribió:
> > Here is a new patch for the line type, with a new input/output format
> > {A,B,C}, as discussed in this thread.
>
> I gave this a quick look. The new input/output format appears to work
> well. The input format using two points still works, which is nice.
> Regression tests pass. I tried binary input and output using COPY and
> it seems to round-trip without problem.
>
> With the two-point input, horizontal and vertical lines can accept NaNs
> without producing a NaN in the output if not necessary.
>
> I tried "interpt" and "intersect" functions and they seem to work.
> Haven't gotten around to trying other functions or operators.

Should the things you tried and others be in the regression tests? If
so, should we start with whatever had been in the regression tests
when the line type was dropped?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-09-17 01:08:48 Re: Dead function argument?
Previous Message Andres Freund 2013-09-16 22:52:19 Re: record identical operator

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Alvaro Herrera 2013-09-17 02:04:09 Re: [PATCH] Revive line type
Previous Message Alvaro Herrera 2013-09-16 22:04:32 Re: [PATCH] Revive line type