| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Vesa-Matti J Kari <vmkari(at)cc(dot)helsinki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Strange hanging bug in a simple milter |
| Date: | 2013-09-13 19:03:31 |
| Message-ID: | 20130913190331.GY2706@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Andres Freund (andres(at)2ndquadrant(dot)com) wrote:
> It seems slightly cleaner to just move the pqsecure_destroy(); to the
> end of that function, based on a boolean. But if you think otherwise, I
> won't protest...
Hmm, agreed; I had originally been concerned that the SIGPIPE madness
needed to be around the pqsecure_destroy() call, but I can't see why
that would be.
I've run through a few times w/ the attached and haven't seen the
deadlock. Will continue testing, of course.
Heikki, any thoughts regarding this change? Any concerns about
back-patching it?
Thanks,
Stephen
| Attachment | Content-Type | Size |
|---|---|---|
| move_call.diff | text/x-diff | 672 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2013-09-13 19:14:25 | Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE |
| Previous Message | Andrew Gierth | 2013-09-13 19:03:01 | Re: UNNEST with multiple args, and TABLE with multiple funcs |