Re: Should we remove "not fast" promotion at all?

On 2013-08-08 12:50:31 -0400, Bruce Momjian wrote:
> On Thu, Aug 8, 2013 at 01:27:35PM +0900, Michael Paquier wrote:
> > > Why are we suddenly trying to make this even more complicated? It's too
> > > late to redesign stuff without very good evidence that it's
> > > needed. Renaming trigger files and changing their format certainly
> > > doesn't seem appropriate post-beta.
> > >
> > > Let's just leave this as is, and remove the code in 9.4/9.5.
> > Sorry. I should have been clearer. I meant that for 9.4~ only. For 9.3
> > yes it's too late.
>
> We seem to be all over the map with the fast promotion code --- some
> people don't trust it, some people want an option to enable the old
> method, and some people want the old method removed.
>
> This has left us in an odd situation where we are going to ship 9.3
> old-method code with no way to enable it in case we need it.

That's not true. It's relatively easy to trigger it. You just can't use
pg_ctl. Which seems completely fine for debugging.

Imo there's no need to do anything. Which is what we've concluded on
before...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services