Re: Backup throttling

From: Gibheer <gibheer(at)zero-knowledge(dot)org>
To: Antonin Houska <antonin(dot)houska(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Backup throttling
Date: 2013-07-31 05:13:36
Message-ID: 20130731071336.1491c25b@linse.fritz.box
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 24 Jul 2013 09:20:52 +0200
Antonin Houska <antonin(dot)houska(at)gmail(dot)com> wrote:

> Hello,
> the purpose of this patch is to limit impact of pg_backup on running
> server. Feedback is appreciated.
>
> // Antonin Houska (Tony)

Hi,

That is a really nice feature. I took a first look at your patch and
some empty lines you added (e.g. line 60 your patch). Can you remove
them?

Why did you move localGetCurrentTimestamp() into streamutil.c? Is
sys/time.h still needed in receivelog.c after the move?

I will try your patch later today to see, if it works.

regards,

Stefan Radomski

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-07-31 05:22:56 Re: pass-through queries to foreign servers
Previous Message Peter Geoghegan 2013-07-31 02:31:44 Re: Computer VARSIZE_ANY(PTR) during debugging