Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs

From: hubert depesz lubaczewski <depesz(at)depesz(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs
Date: 2013-07-30 10:09:53
Message-ID: 20130730100952.GA3872@depesz.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 30, 2013 at 09:23:19AM +0100, Dean Rasheed wrote:
> >> > > create table some_data (id int4 primary key, payload text);
> >> > > create view first as select * from some_data where 0 = id % 2 with local check option;
> >> > > create view second as select * from first where 0 = id with local check option;
> > [...]
> >> the check is "0 = id % 3" - i.e. id has to be multiply of 3. Sorry if my
> >> way of writing conditionals is confusing.
> Yes it definitely looks like a typo in the test --- the definition of
> "first" has "id % 2", so it is checking for even numbers, not for
> numbers divisible by 3.

Sorry, my bad - must have screwed copy/paste.
the second view is:
select * from first where 0 = id % 3 with local check option;

> As for the point about which of the checks should be failing, I
> believe that the current behaviour is correct.

In such case, can you show me what is the difference of "local check"
and "cascaded check"?
Because I assumed, after reading the commit log, that local checks just
the view definition of the view I'm inserting to, and the cascaded
check, checks all the views "upstream".

Given the assumption that current code works correctly - both checks
check also the upstream view.

Best regards,

depesz

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2013-07-30 10:45:47 Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs
Previous Message Dean Rasheed 2013-07-30 08:23:19 Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2013-07-30 10:45:47 Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs
Previous Message Dean Rasheed 2013-07-30 08:23:19 Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs