From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: pg_upgrade -j broken on Windows |
Date: | 2013-07-27 19:01:14 |
Message-ID: | 20130727190114.GB3106@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 26, 2013 at 01:31:45PM -0400, Bruce Momjian wrote:
> On Fri, Jul 26, 2013 at 01:27:34PM -0400, Bruce Momjian wrote:
> > On Thu, Jul 25, 2013 at 10:57:28AM -0400, Bruce Momjian wrote:
> > > Everyone should be aware that the 9.3 pg_upgrade -j/--jobs option on
> > > Windows is currently broken, and hopefully will be fixed by the next
> > > beta.
> > >
> > > Someone at PGDay UK told me they were getting pg_upgrade -j crashes on
> > > Windows. Andrew Dunstan was able to reproduce the crash, and that has
> > > been fixed, but there is still a race condition that I am trying to
> > > diagnose.
> >
> > After three days of testing and creating a Windows MinGW build
> > environment (with Andrew's help), I have come up with the attached patch
> > which fixes the pg_upgrade -j race condition on Windows. In summary,
> > creating a file with fopen() from a non-primary thread and then calling
> > system() soon after can result in a file-in-use error. The solution was
> > to issue the fopen() after system() in such cases.
> >
> > This would be applied to head and 9.3.
>
> Sorry, patch attached.
Applied, and backpatched to 9.3.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Euler Taveira | 2013-07-27 20:17:08 | Re: comment for "fast promote" |
Previous Message | Dimitri Fontaine | 2013-07-27 18:24:45 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |