Re: make --silent

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make --silent
Date: 2013-07-23 13:21:54
Message-ID: 20130723132154.GF15510@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Andres Freund (andres(at)2ndquadrant(dot)com) wrote:
> On 2013-07-23 08:38:03 -0400, Peter Eisentraut wrote:
> > Writing postgres.bki
> > Writing schemapg.h
> > Writing postgres.description
> > Writing postgres.shdescription
> > Writing fmgroids.h
> > Writing fmgrtab.c
>
> I personally don't feel the need for those to go away. They only appear
> when doing a clean rebuild and/or when changing something
> significant. Also it's just a couple of lines.

For my 2c, I'd be for getting rid of the above. I agree it's not a huge
deal, but I'm also a big fan of "don't spam me when things go right".
Is there any particular reason we need to see them with every (clean)
build..?

> > Processing HTML.index...
> > 2406 entries loaded...
> > 0 entries ignored...
> > Done.
> > Note: Writing man3/SPI_connect.3
> > Note: Writing man3/SPI_finish.3
> > Note: Writing man3/SPI_push.3
> > ...
> > Note: Writing man1/pg_test_timing.1
> > Note: Writing man1/pg_upgrade.1
> > Note: Writing man1/pg_xlogdump.1
>
> Those should imo be silenced. It's quite a bit of output, and especially
> during a parallel build they tend to hide more important output.

Agreed.

> > In file included from gram.y:13612:0:
> > scan.c: In function ‘yy_try_NUL_trans’:
> > scan.c:10181:23: warning: unused variable ‘yyg’ [-Wunused-variable]
> > PostgreSQL, contrib, and documentation successfully made. Ready to install.
>
> FWIW, I've patched debian's flex just to get rid of this ;)

Any idea if that might be accepted upstream or perhaps by Debian..? It
would surely be nice to make that error go away..

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2013-07-23 13:22:56 Re: [9.4 CF 1] And then there were 5
Previous Message Greg Stark 2013-07-23 13:17:13 Re: Suggestion for concurrent index creation using a single full scan operation