| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | levertond(at)googlemail(dot)com, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #8273: Assertion failure in 9.3 beta2 with serializable and savepoints |
| Date: | 2013-07-20 00:06:57 |
| Message-ID: | 20130720000657.GI4130@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund wrote:
> On 2013-07-19 13:46:44 -0400, Alvaro Herrera wrote:
> > Sadly, this has performance implications, because what previously was
> > just an in-place check of bit flags has now become a function call.
>
> Well, the impact imo primarily comes from actually resolving the
> multixact, not from the function call itself... But I don't think we
> need to overly worried. That path is only entered if xmin is
> in-progress, so that shouldn't have too big implications.
True. I have pushed it, with this tweak:
> > Perhaps it'd be smart to optimize it a bit so that we first check the
> > flags, and only call the function if that fails.
>
> Sounds like a good idea to me. The duplicated amount of work by that
> should by fairly minimal.
Thanks.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sandeep Thakkar | 2013-07-22 05:50:05 | Re: Installer: Spurious "service account ... not removed" on uninstall |
| Previous Message | Alvaro Herrera | 2013-07-19 21:29:03 | Re: BUG #8273: Assertion failure in 9.3 beta2 with serializable and savepoints |