| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | coelho(at)cri(dot)ensmp(dot)fr |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgbench patches |
| Date: | 2013-07-18 01:46:01 |
| Message-ID: | 20130718.104601.511712465900892567.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> Hello Tatsuo,
>>
>>> For me, the error message is not quite right, because progress == 0
>>> case is considered error as well in your patch. I sugges you change
>>> the error message something like:
>>>
>>> "thread progress delay (-P) must be positive number (%s)\n",
>>
>> Please find attached a new version with an updated message.
>
> Thanks. I've been testing on Linux now. Starting from coming Tuesday
> (Monday is a national holiday in Japan) I will test on Mac OS X and
> Windows.
I have done the test on Mac OS X. Windows testing was done by my
coleague, Yugo Nagata. The results were very positive and I committed
--progress patches.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2013-07-18 02:58:16 | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |
| Previous Message | Tatsuo Ishii | 2013-07-18 01:16:29 | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |