| From: | Cédric Villemain <cedric(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: [PATCH] Remove useless USE_PGXS support in contrib |
| Date: | 2013-06-17 17:00:51 |
| Message-ID: | 201306171901.04730.cedric@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le lundi 17 juin 2013 18:41:32, Alvaro Herrera a écrit :
> Joe Conway wrote:
> > On 06/15/2013 11:28 AM, Alvaro Herrera wrote:
> > > This use case seems too narrow to me to justify the burden of
> > > keeping PGXS-enabled makefiles in contrib.
> >
> > What was the burden of it?
>
> Per http://www.postgresql.org/message-
id/1371093408(dot)309(dot)5(dot)camel(at)vanquo(dot)pezone(dot)net :
> : 1. take up space
> : 2. confuse users
> : 3. produce broken external extension modules that take contrib as an
> : example 4. break builds of PostgreSQL when users try to fix 3. by
> : exporting USE_PGXS
But:
4. can be fixed (see patches I sent) so it is not an excuse.
I agree for other points.
My only grief is to loose the perfect regression tests for PGXS those contribs
are.
--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2013-06-17 17:10:21 | Re: matview incremental maintenance |
| Previous Message | Simon Riggs | 2013-06-17 16:50:36 | Re: matview incremental maintenance |