| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_filedump 9.3: checksums (and a few other fixes) |
| Date: | 2013-06-10 17:25:22 |
| Message-ID: | 20130610172522.GH15368@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeff Davis wrote:
> On Mon, 2013-06-10 at 11:38 -0400, Tom Lane wrote:
> > The thing I'm not too happy about is having to copy the checksum code
> > into pg_filedump. We just got rid of the need to do that for the CRC
> > code, and here it is coming back again. Can't we rearrange the core
> > checksum code similarly to what we did for the CRC stuff recently,
> > so that you only need access to a .h file for it?
>
> The CRC implementation is entirely in header files. Do you think we need
> to go that far, or is it fine to just put it in libpgport and link that
> to pg_filedump?
If a lib is okay, use libpgcommon please, not libpgport. But I think a
.h would be better, because there'd be no need to have a built source
tree to build pg_filedump, only the headers installed.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-06-10 17:38:29 | Re: pg_filedump 9.3: checksums (and a few other fixes) |
| Previous Message | Jeff Davis | 2013-06-10 17:10:12 | Re: pg_filedump 9.3: checksums (and a few other fixes) |