From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: pg_ugprade use of --check and --link |
Date: | 2013-06-07 15:14:42 |
Message-ID: | 20130607151442.GA19907@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jun 6, 2013 at 10:24:30AM -0400, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > In a private bug report, I have realized that if you are eventually
> > going to be using link mode with pg_upgrade, and you run --check mode,
> > you should use --link with --check to check that both clusters are on
> > the same file system.
>
> Would it make sense to run the filesystem check anyway, and if the
> check fails say something like "this will fail in --link mode, although
> copy mode might work" ?
I thought about that, but the problem is that the return value of
--check should be success/fail. We could do the check always, and issue
a warning, but you would still need to use --link with --check if you
wanted a valid return value --- that seemed just too awkward.
Documenting the --link requirement seemed clearer.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2013-06-07 15:15:38 | Re: Proposal for CSN based snapshots |
Previous Message | Tom Lane | 2013-06-07 15:05:21 | Re: system catalog pg_rewrite column ev_attr document description problem |