| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Naoya Anzai <anzai-naoya(at)mxu(dot)nes(dot)nec(dot)co(dot)jp>, pgsql-bugs(at)postgresql(dot)org, Akio Iwaasa <iwaasa(at)mxs(dot)nes(dot)nec(dot)co(dot)jp> |
| Subject: | Re: Memory-leak in BackgroundWriter(and Checkpointer) |
| Date: | 2013-06-04 13:49:27 |
| Message-ID: | 20130604134927.GI5871@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
* Andres Freund (andres(at)2ndquadrant(dot)com) wrote:
> On 2013-06-04 16:23:00 +0300, Heikki Linnakangas wrote:
> > I can't get too excited about the overhead of a single palloc here. It's a
> > fairly heavy operation anyway, and only runs once per checkpoint. And we
> > haven't heard any actual complaints of latency hiccups with
> > wal_level=hot_standby.
Perhaps, but we don't always hear about things that we should- this long
standing memory leak being one of them.
> Seems more consistent with the rest of the code too. But anyway, I am
> fine with fixing it either way.
And this is really the other point- having LogStandbySnapshot() need to
clean up after GetRunningTransactionLocks() but not
GetRunningTransactionData() would strike me as very odd.
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua Berry | 2013-06-04 14:46:39 | Re: Segmentation Fault in Postgres server when using psqlODBC |
| Previous Message | Andres Freund | 2013-06-04 13:27:58 | Re: Memory-leak in BackgroundWriter(and Checkpointer) |