Re: Running pgindent

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Running pgindent
Date: 2013-05-31 20:09:45
Message-ID: 20130531200945.GE1728@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 31, 2013 at 03:51:30PM -0400, Andrew Dunstan wrote:
>
> On 05/29/2013 11:41 PM, Bruce Momjian wrote:
> >On Wed, May 29, 2013 at 10:08:10PM -0400, Stephen Frost wrote:
> >>* Bruce Momjian (bruce(at)momjian(dot)us) wrote:
> >>>Wow, uh, yeah, I guess we could do that. I will await more feedback.
> >>Please don't. I'm already rather concerned by this one. It looks like
> >>there's a rule to pull a line in to meet the max-column requirement even
> >>when that makes things line up 'funny', eg:
> >I did a comparison of the parameters passed to BSD indent, and Andrew
> >did accurately transfer all the flags, so I am a little confused why
> >there is such a difference, as BSD indent has not changed.
>
> I spent quite a lot of time trying to make the tool behave the same
> as the old script.

Yes, and I believe we tested running the Perl version to make sure it
was the same, so the changes we are seeing are just normal (unfortunate)
adjustments by pgindent.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2013-05-31 20:18:06 Re: Unsigned integer types
Previous Message Andres Freund 2013-05-31 20:06:40 Re: detecting binary backup in progress