From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in VACUUM reporting of "removed %d row versions" in 9.2+ |
Date: | 2013-05-10 18:55:40 |
Message-ID: | 20130510185539.GE17166@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas escribió:
> I think this patch as currently written is going to leave us with the
> following dubious-looking construct.
>
> if (!ConditionalLockBufferForCleanup(buf))
> {
> if (!ConditionalLockBufferForCleanup(buf))
> {
>
> Modulo that minor gripe, I think it's definitely worth doing this in
> master. I'm a bit disinclined to change the message string in 9.2,
> and therefore might not back-patch at all, since there's basically no
> consequence to this except for mildly inaccurate reporting. But if
> people feel it's worth a translation break for this, I don't object to
> back-patching it either.
We break translations to fix bugs from time to time. Translators do
update for minor releases, so if this is the only consideration, I don't
think we should hold this bugfix for it (or any other, IMV).
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2013-05-10 19:10:28 | Re: [patch] PSQLDIR not passed to pg_regress in contrib/pg_upgrade/test.sh |
Previous Message | Robert Haas | 2013-05-10 18:37:20 | Re: Bug in VACUUM reporting of "removed %d row versions" in 9.2+ |