[patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

From: Christoph Berg <cb(at)df7cb(dot)de>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations
Date: 2013-05-07 06:51:47
Message-ID: 20130507065146.GG5150@msgid.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"make check" supports EXTRA_REGRESS_OPTS to pass extra options to
pg_regress, but all the other places where pg_regress is used do not
allow this. The attached patch adds EXTRA_REGRESS_OPTS to
Makefile.global.in (for contrib modules) and two more special
Makefiles (isolation and pg_upgrade).

The use case here is that Debian needs to be able to redirect the unix
socket directory used to /tmp, because /var/run/postgresql isn't
writable for the buildd user. The matching part for this inside
pg_regress is still in discussion here, but the addition of
EXTRA_REGRESS_OPTS is an independent step that is also useful for
others, so I'd like to propose it for inclusion.

Christoph
--
cb(at)df7cb(dot)de | http://www.df7cb.de/

Attachment Content-Type Size
extra_regress_opts.patch text/x-diff 4.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matt Clarkson 2013-05-07 07:19:25 Re: In progress INSERT wrecks plans on table
Previous Message Christoph Berg 2013-05-07 06:40:48 [patch] PSQLDIR not passed to pg_regress in contrib/pg_upgrade/test.sh