Re: pgsql: pg_test_fsync: update output to show usecs/op clearer

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_test_fsync: update output to show usecs/op clearer
Date: 2013-05-02 16:08:45
Message-ID: 20130502160845.GB24822@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, May 2, 2013 at 08:38:39AM -0700, Peter Geoghegan wrote:
> On Thu, May 2, 2013 at 7:27 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > pg_test_fsync: update output to show usecs/op clearer
>
> I don't think that this is an improvement. Not everyone knows that
> usec is shorthand for microsecond. If I Google usec, I see something
> about the United States Enrichment Corporation, but that's about it.

Well, we use 'usecs' all over our code, and in pg_test_timing:

Histogram of timing durations:
< usec % of total count
1 95.86499 69510498
2 4.13395 2997478
4 0.00062 453
8 0.00042 301
16 0.00001 8
32 0.00000 1

Microseconds just isn't going to fit there. Postgres understands usec:

test=> select '1 usec'::interval;
interval
-----------------
00:00:00.000001
(1 row)

I think the people running these tools are going to know usec.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2013-05-02 16:09:22 Re: pgsql: pg_test_fsync: update output to show usecs/op clearer
Previous Message Dimitri Fontaine 2013-05-02 15:44:07 Re: pgsql: pg_test_fsync: update output to show usecs/op clearer