| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to make pgindent work cleanly |
| Date: | 2013-04-12 19:26:47 |
| Message-ID: | 20130412192647.GE28226@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 12, 2013 at 01:34:49PM -0400, Gurjeet Singh wrote:
> Can you also improve the output when it dies upon failure to fetch something?
> Currently the only error message it emits is "fetching xyz", and leaves the
> user confused as to what really the problem was. The only indication of a
> problem might be the exit code, but I'm not sure of that, and that doesn't
> help the interactive user running it on terminal.
Good point. I have reviewed all the error messages and improved them
with the attached, applied patch, e.g.:
cannot locate typedefs file "xyz" at /usr/local/bin/pgindent line 121.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| Attachment | Content-Type | Size |
|---|---|---|
| pgindent.diff | text/x-diff | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-04-12 19:28:42 | Re: Enabling Checksums |
| Previous Message | Bruce Momjian | 2013-04-12 19:21:46 | Re: Enabling Checksums |