Re: Ignore invalid indexes in pg_dump.

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Ignore invalid indexes in pg_dump.
Date: 2013-03-28 22:08:07
Message-ID: 20130328220807.GC28736@alap2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2013-03-28 17:54:08 -0400, Bruce Momjian wrote:
> On Thu, Mar 28, 2013 at 10:47:55PM +0100, anarazel(at)anarazel(dot)de wrote:
> >
> >
> > Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> schrieb:
> >
> > >"anarazel(at)anarazel(dot)de" <andres(at)anarazel(dot)de> writes:
> > >> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> schrieb:
> > >>> Yeah, if you can just ignore !indisvalid indexes that should work
> > >fine.
> > >>> I see no need to look at indisready if you're doing that.
> > >
> > >> You need to look at inisready in 9.2 since thats used for about to
> > >> be
> > >dropped indexes. No?
> > >
> > >No, he doesn't need to look at indisready/indislive; if either of
> > >those flags are off then indisvalid should certainly be off too. (If
> > >it isn't, queries against the table are already in trouble.)
> >
> > 9.2 represents inisdead as live && !ready, doesn't it? So just looking
> > at indislive will include about to be dropped or partially dropped
> > indexes?
>
> Where do you see 'inisdead' defined?

Sorry, its named the reverse, indislive. And its only there in 9.3+...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-03-28 22:27:48 Re: Ignore invalid indexes in pg_dump.
Previous Message Bruce Momjian 2013-03-28 21:54:08 Re: Ignore invalid indexes in pg_dump.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-03-28 22:27:48 Re: Ignore invalid indexes in pg_dump.
Previous Message Bruce Momjian 2013-03-28 21:54:08 Re: Ignore invalid indexes in pg_dump.