From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: sql_drop Event Triggerg |
Date: | 2013-03-27 15:54:37 |
Message-ID: | 20130327155437.GB3702@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera escribió:
> Alvaro Herrera escribió:
>
> > However, I think previous discussions have conflated many different
> > things, and we've been slowly fixing them one by one; so perhaps at this
> > point it does make sense to have a new object-drop event. Let's discuss
> > it -- we would define it as taking place just before ddl_command_end,
> > and firing any time a command (with matching tag?) has called
> > performDeletion or performMultipleDeletions. Does that sound okay?
> [1mdiff --git a/doc/src/sgml/event-trigger.sgml b/doc/src/sgml/event-trigger.sgml[m
> [1mindex 71241c8..492a4ed 100644[m
> [1m--- a/doc/src/sgml/event-trigger.sgml[m
> [1m+++ b/doc/src/sgml/event-trigger.sgml[m
Uh, seems I posted the --color version of the patch last night. Easy
mistake to make. Here's a readable version (context diff, even), with a
couple of bugs fixed that I noticed while writing the final docs. Some
random minor cleanup too. I also took the opportunity to refactor some
common code in the invoking sequence of existing events; there was way
too much unnecessary duplication there.
This horse is about to become corpse; last chance for beating it up.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
dropped_objects.11.patch | text/x-diff | 70.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2013-03-27 16:10:02 | Re: [COMMITTERS] pgsql: Allow external recovery_config_directory |
Previous Message | Heikki Linnakangas | 2013-03-27 15:35:53 | Re: [COMMITTERS] pgsql: Allow external recovery_config_directory |