| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |
| Date: | 2013-03-26 17:59:34 |
| Message-ID: | 20130326175934.GA3881@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Heikki Linnakangas wrote:
> This is what I came up with. I created a new file, misc.c (for lack
> of a better name), for things that are shared by pg_dump and
> pg_restore, but not pg_dumpall or other programs. I moved all the
> parallel stuff from dumputils.c to parallel.c, and everything else
> that's not used outside pg_dump and pg_restore to misc.c. I moved
> exit_horribly() to parallel.c, because it needs to do things
> differently in parallel mode.
Not happy with misc.c as a filename. How about pg_dump_utils.c or
pg_dump_misc.c? I think the comment at the top should explicitely say
that the file is intended not to be linked in pg_dumpall.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-03-26 20:14:53 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |
| Previous Message | Heikki Linnakangas | 2013-03-26 17:26:26 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2013-03-26 18:05:39 | Re: Support for REINDEX CONCURRENTLY |
| Previous Message | Kevin Grittner | 2013-03-26 17:50:27 | Re: Limiting setting of hint bits by read-only queries; vacuum_delay |