npgsql - Npgsql2: [#1011310] Command timeouts after the first are not

From: fxjr(at)cvs(dot)pgfoundry(dot)org
To: pgsql-committers(at)postgresql(dot)org
Subject: npgsql - Npgsql2: [#1011310] Command timeouts after the first are not
Date: 2013-02-27 13:06:40
Message-ID: 201302271306.r1RD6ehL007398@cvs.pgfoundry.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------

[#1011310] Command timeouts after the first are not handled. Applied patch [#1011311]. Thank you, Evan Martin, for bug report and patch!

When a command inside a transaction times out the caller may roll back to a savepoint and try again. This works OK the first time. The second time it appears to work, but the rollback takes a long time. On the third attempt the command returns an empty result set. The attached console app reproduces the problem. On investigation, it appears that Npgsql is not cancelling any command after the first, once NpgsqlConnector.CancelRequestCalled is true.

Modified Files:
--------------
Npgsql2/src/Npgsql:
NpgsqlConnector.cs (r1.39 -> r1.40)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlConnector.cs?r1=1.39&r2=1.40)
NpgsqlReadyState.cs (r1.6 -> r1.7)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlReadyState.cs?r1=1.6&r2=1.7)
NpgsqlState.cs (r1.24 -> r1.25)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlState.cs?r1=1.24&r2=1.25)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-02-27 15:41:02 pgsql: Add missing error check in regexp parser.
Previous Message Heikki Linnakangas 2013-02-27 12:54:53 Re: [COMMITTERS] pgsql: Fix pg_dumpall with database names containing =