| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Claudio Freire <klaussfreire(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Ants Aasma <ants(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
| Subject: | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |
| Date: | 2013-02-25 14:11:27 |
| Message-ID: | 20130225141127.GO16142@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
Then let's change it, drop the preference, and update the documentation.
I'd certainly prefer that to getting shot for pointing out to patch
submitters that they're not following our documented guidelines.
> Everyone here who reviews patches regularly knows how to, and probably
> does, convert between those formats with regularity. Making patch
> submitters feel badly because they've used the "wrong" format does not
> advance the goals of the project.
For my part, I'd rather put the onus on the submitter to submit a
readable patch in the first part than ask the reviewer and anyone else
interested in looking at the patch to fix it. That's even more true
when you consider the archives and reading patches through the web
interface (though downloading the original mail message has gotten
better with the new archive code).
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-02-25 14:17:25 | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |
| Previous Message | Tom Duffey | 2013-02-25 14:08:57 | Re: Floating point error |