Re: pgsql: Blind attempt at fixing the non-MSVC Windows builds

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Blind attempt at fixing the non-MSVC Windows builds
Date: 2013-02-22 14:59:37
Message-ID: 20130222145936.GF19114@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2013-02-22 14:55:06 +0000, Alvaro Herrera wrote:
> Blind attempt at fixing the non-MSVC Windows builds
>
> Apparently, they need -DBUILDING_DLL for the Assert() declarations to
> work correctly.

More specifically, they need that do access any PGDLLIMPORT symbols. Of
which
extern PGDLLIMPORT bool assert_enabled;
is one. So that seems like the appropriate fix.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2013-02-22 15:34:19 Re: pgsql: Blind attempt at fixing the non-MSVC Windows builds
Previous Message Alvaro Herrera 2013-02-22 14:56:57 Re: pgsql: Move relpath() to libpgcommon