Re: Materialized views WIP patch

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Marko Tiikkaja <pgmail(at)joh(dot)to>, Greg Stark <stark(at)mit(dot)edu>
Subject: Re: Materialized views WIP patch
Date: 2013-02-21 23:32:08
Message-ID: 20130221233208.GA19114@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2013-02-21 14:11:10 -0800, Kevin Grittner wrote:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
>
> >> What did you think of the idea of something like DISCARD
> >> MATERIALIZED VIEW DATA as a new statment?  Or maybe RESET
> >> MATERIALIZED VIEW?
> >
> > I could live with either DISCARD or RESET.
>
> I figured this was worth a pass through the keyword list to look
> for all imperative verbs suitable for this, which could support the
> needed syntax without adding a new keyword.  Here are the
> possibilities I came up with, along with a note about why they are
> keywords already.
>
> DISABLE MATERIALIZED VIEW mv;  -- ALTER clause for constraints
> DISCARD MATERIALIZED VIEW DATA mv;  -- session state
> RELEASE MATERIALIZED VIEW DATA mv;  -- savepoint
> RESET MATERIALIZED VIEW DATA mv;  -- run-time parameter
>
> I think any of these could work.  I'm personally most inclined
> toward DISABLE MATERIALIZED VIEW.  It seems to convey the semantics
> better, especially if you leave out DATA as an additonal word.

> Given that a materialized view will retain its query, tablespace,
> indexes, statistics targets, etc. with this operation, and will
> just not be available for scanning, some of the above seem
> downright misleading without DATA thrown in.

I vote for RESET or DISCARD. DISABLE sounds more like you disable
automatic refreshes or somesuch.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2013-02-22 01:49:54 pgsql: Move relpath() to libpgcommon
Previous Message Kevin Grittner 2013-02-21 22:46:40 Re: Materialized views WIP patch

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2013-02-22 00:13:53 Re: 9.2.3 crashes during archive recovery
Previous Message Ian Lawrence Barwick 2013-02-21 23:25:31 Re: [HACKERS] Contrib module "xml2" status