| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: overlapping strncpy/memcpy errors via valgrind |
| Date: | 2013-02-17 15:19:37 |
| Message-ID: | 20130217151937.GB5073@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-02-17 15:10:35 +0000, Greg Stark wrote:
> Peter G is sitting near me and reminded me that this issue came up in the
> past. Iirc the conclusion then is that we're calling memcpy where the
> source and destination pointers are sometimes identical. Tom decided there
> was really no realistic architecture where that wouldn't work.
I am not so convinced that that is safe if libc turns that into some
optimized string instructions or even PCMPSTR...
> We're not calling it on overlapping nonidentical pointers.
Yup, the backtrace shows that...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-02-17 15:32:07 | Re: overlapping strncpy/memcpy errors via valgrind |
| Previous Message | Phil Sorber | 2013-02-17 15:13:34 | Re: [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq |